Re: [xine-devel] Re: Framebuffer output plugin

[Miguel F. <mi...@ce...>]

On Sun, 2002-01-13 at 20:38, Steven Walter wrote:
> On Sun, Jan 13, 2002 at 03:54:20PM -0600, Steven Walter wrote:
> > I notice that the fb output plugin doesn't like DIRECTCOLOR
> > framebuffers.  I use the tdfx fb driver, and this (along with
> > PSEUDOCOLOR) are all it supports.  What's the difference between
> > DIRECTCOLOR and TRUECOLOR?  Is there any particularly large obstacle
> > keeping the plugin from working with DIRECTCOLOR displays?
> 
> Hmm... apparently not.  I tried just changing all references of
> FB_VISUAL_TRUECOLOR to FB_VISUAL_DIRECTCOLOR, and everything worked
> fine, if not a little slowly.  So, here is a patch against the latest
> CVS that lets video_out_fb.c work with both DIRECTCOLOR and TRUECOLOR
> framebuffers.

Hi Steven,

You should notice that framebuffer is marked as experimental, i coded it
in about 3 hours and it haven't being much tested. That said, i really
appreciate any bug reports! :)

I'm no framebuffer specialist but i guess DIRECTCOLOR may be configured
to emulate a TRUECOLOR if we load linear r,g and b palettes. That is, it
may have worked by luck for you if your fb was already configured with
linear palettes. We should force loading color maps to have proper
DIRECTCOLOR support.

I will try to implement it but i'm bit out of time this week. If you can
look forward fixing the video_out_fb.c the right way i will happily
apply your patches.

regards,

Miguel