From: SourceForge.net <no...@so...> - 2007-02-18 14:34:07
|
Bugs item #1644312, was opened at 2007-01-25 11:06 Message generated for change (Settings changed) made by dsalt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1644312&group_id=9655 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: xine-lib >Group: current cvs version Status: Open Resolution: None Priority: 5 Private: No Submitted By: Martin Sourada (martin_sourada) >Assigned to: Nobody/Anonymous (nobody) Summary: post eq2 causes segfault with some files Initial Comment: I have a issue with eq2 post-processing plugin in gxine 0.5.10. It causes gxine to crash when playing a movie. Strange is, that it happens only to some movies and not always. However, I don't see any pattern for it. It might be similar to bug #1625339. Steps to reproduce: 1. Set eq2 in video post-processing and turn it on 2. Add a movie to a playlist. 3. Double click on the movie in the playlist Result: Occasionally, one of the first scenes shows and hangs, audio plays still, segfault dialog appears, and gxine hangs (with audio still playing). ---------------------------------------------------------------------- Comment By: lorenzodes (lorenzoedes) Date: 2007-01-25 17:28 Message: Logged In: YES user_id=1655097 Originator: NO ->604 width = (i==0) ? frame->width : frame->width/2 should read ->604 width = (i==0) ? frame->width : frame->width/2; sorry for the typo. ---------------------------------------------------------------------- Comment By: lorenzodes (lorenzoedes) Date: 2007-01-25 17:27 Message: Logged In: YES user_id=1655097 Originator: NO Re: bug #1625339. There's a bug in /xine-lib/src/post/planar/eq2.c. Basically the following: 601 for (i = 0; i < 3; i++) { 602 int height; 603 height = (i==0) ? frame->height : frame->height/2; 604 605 if (eq2->param[i].adjust != NULL) { 606 eq2->param[i].adjust (&eq2->param[i], out_frame->base[i], yv12_frame->base[i], 607 frame->width, height, out_frame->pitches[i], yv12_frame->pitches[i]); 608 } 609 else { 610 xine_fast_memcpy(out_frame->base[i],yv12_frame->base[i], 611 yv12_frame->pitches[i] * height); 612 } 613 } Should be: 601 for (i = 0; i < 3; i++) { ->602 int height, width; 603 height = (i==0) ? frame->height : frame->height/2; ->604 width = (i==0) ? frame->width : frame->width/2 605 if (eq2->param[i].adjust != NULL) { 606 eq2->param[i].adjust (&eq2->param[i], out_frame->base[i], yv12_frame->base[i], ->607 width, height, out_frame->pitches[i], yv12_frame->pitches[i]); 608 } 609 else { 610 xine_fast_memcpy(out_frame->base[i],yv12_frame->base[i], 611 yv12_frame->pitches[i] * height); 612 } 613 } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1644312&group_id=9655 |