Re: [xine-devel] PTS values are 33 bits, why store them in uint32 ?

[Michel L. <wa...@zo...>]

On Sun, Jul 08, 2001 at 06:18:20PM +0200, Guenter Bartsch wrote:
> > The amount of bits extracted are 33 bits.
> > Why is this stored in just 32 bits.
> > I assume this could cause quite a few problems.

The PTS will wrap around eventually, so this does not make a big
difference.  It will just wrap after 13 hours instead of 26. We dont
care, since we never have to compare dates that are very far away in
time (say more than a few seconds).

> > I propose to change this to store PTS and DTS values in uint64 or 64 bit
> > values instead of 32 bit values.

> oki, if this doesn't have any major impact on performance, this is surely
> a cleaner solution. Only one way to find out (about performance) : try
> it.

Having a 32-bit value actually helps handling the wraparounds: we can just
calculate time1 - time2 and this value is never affected by any wraparound.
So this is really quite convenient. If we switched to uint64, we would have
to be more careful.

I would say 32-bit values are nicer overall.

-- 
Michel "Walken" LESPINASSE
Of course I think I'm right. If I thought I was wrong, I'd change my mind.