Re: [xine-devel] [PATCH] Complete rewrite of vdpau output driver osd handling

[Christophe T. <hf...@fr...>]

Le mardi 3 janvier 2012 15:13:33, Andreas Auras a écrit :
> Complete rewrite of vdpau output driver osd handling.
> The new implementation has the following advantages towards the existing
> one:
> There is now a unique processing of RLE coded images and ARGB based
> overlay images.
> For both formats scaled and unscaled images and a video window are
> supported.
> Both formats are rendered now in given order into the same output
> surface not using
> a dedicated output surface for scaled, unscaled and ARGB images any
> more.
> Processing of YCBCR overlay images now uses corresponding vdpau upload
> functions
> eliminating the existing (possible slower) conversation to RGB images.
> Optimized processing of first overlay from stack avoiding unnecessary
> surface initialization and rendering operations.
> Currently the new implementation does only take the dirty rect
> information of a ARGB overlay into account for optimization
> if this is the only one object that should be displayed.
> 
> Note: This is the completely revised version of the patch from April,
> 2011
> 
> - Andreas

Hi Andreas,

Could you please try playing dvb (or dvd?) subtitles.
You are propably going to see the placement problem.
Please also try HDTV+dvbsub, where subs are generally 720x576. Prior to your 
patches it was streched to the video size.
It also seems that sometimes there is a short (probably 1 frame) "more or less 
trasnlucent gray" flash when overlay appears or disappears.

-- 
Christophe Thommeret