Re: [xine-devel] [PATCH 2 of 2] ffmpeg video: do not require preview buffers for mpeg1/2

[Petri H. <phi...@us...>]

Chris Rankin wrote:
> On 16/09/11 09:16, Petri Hintukainen wrote:
> > +      if ((buf->type&  0xFFFF0000) == BUF_VIDEO_MPEG) {
> >   	ff_handle_mpeg12_buffer(this, buf);
> 
> Hi Petri,
> 
> By "0xFFFF0000", are you really meaning "(BUF_MAJOR_MASK | BUF_DECODER_MASK)"?

Yes, to clear logical channel number from buffer type.

> Although we could probably use a new MASK constant, as (BUF_MAJOR_MASK | 
> BUF_DECODER_MASK) seems to be needed quite often.

BUF_CHANNEL_MASK 0x0000ffff or BUF_TYPE_MASK 0xffff0000 (?)


- Petri