Re: [xine-devel] [PATCH] Several fixes/improvements for CD playback

[Christopher M. <chr...@ut...>]

On April 25, 2009 14:03:32 Darren Salt wrote:
> I demand that Christopher Martin may or may not have written...
>
> > Please consider the attached patch, cdda_improvements.diff. It
> > makes several changes to the CDDA plugin and associated files,
> > explained below:
> >
> > 1) Apply CD-related gapless patches from
> > http://hg.debian.org/hg/xine-lib/xine-lib-gapless, avoiding
> > noticeably flawed track transitions.
>
> NAK. Your patch should be against that repository; however, I'll
> merge that into the main repository.

OK, now that you've merged the gapless branch, we still need to:

1) Apply the same fix (just applied to demux_wav.c) to demux_cdda.c 
(cdda_improvements1.diff); and
2) Adjust the CDDA frame cache to a 'snappier' value 
(cdda_improvements2.diff).

> > 2) Make use of the DGENRE information provided by CDDB. Many
> > frontends support it; we just weren't bothering to use it. Also
> > improves track number reporting. Based on an unused patch by Markus
> > Kaufhold in the bug database.*
>
> Would be better to build on top of that patch, then; should be a
> separate patch.

cdda_improvements3.diff - this is basically the same as Markus 
Kaufhold's patch. The bug (and patch) don't seem to exist in the 
current bugzilla anymore (but I'd saved it locally a while ago). 
However, the original report can be found at:

http://sourceforge.net/mailarchive/forum.php?thread_name= \ 
E1FI2Xj-0001tC-Rk%40sc8-sf-web3.sourceforge.net&forum_name=xine-bugs

> > 3) Complete the fix started in
> > http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=827afe
> >1c3777;style=gitweb
> >
> > Explanation: Replacing strrchr with strchr to allow disc and track
> > titles to contain "=" when parsing CDDB is great; this makes a few
> > more replacements that were missed by the original patch.
>
> Should be a separate patch.

cdda_improvements4.diff (applies on top of cdda_improvements3.diff).

Hope that helps.