From: Alan N. <ala...@gm...> - 2008-06-24 21:30:01
|
I was asked to send this patch to xine-devel by Darren Salt. It implements support for communicating with the dshowserver (coreavc-for-linux.googlecode.com) This is mainly useful for using CoreAVC in Linux (a very fast H264 decoder), however it could be made to work with other win32 codecs. The code is based on mplayer's libloader (which xine already includes in modified form) but using a separate server allows for several benefits: a) easy to support in multiple players (mythtv, xine, mplayer) since the dshowserver patch is small, and all the win32 stuff is centralized b) can use 32bit win32 codecs with players compiled in 64-bit mode c) a crash in the codec does not bring down the player I have addressed many of the issues he requested I address except for: * The plugin description should be translatable (use N_() for this) I don't see any examples of other plugins doing this, so I wasn't sure how to proceed. * Documentation patches I have no idea what he wanted here. * Fixed-size buffers should be avoided wherever practical, e.g. use asprintf() where it makes sense to do so. I did move the constant-sized strings (snprintf) to use asprintf as requested, but this really didn't feel like the right thing to do to me. The code is built against the xinelib 1.1 branch, and will require a some change to work in 1.2 |