Re: [xine-devel] Partial fix to bug playing flash videos from

[Phoenix R. <pho...@ya...>]

> From: Darren Salt <li...@yo...>
> 
>   $ hg clone http://hg.debian.org/hg/xine-lib/xine-lib
>   $ cd xine-lib
>   $ hg bisect init
>   $ hg bisect good xine-1_1_4-release
>   $ hg bisect bad xine-lib-1_1_5-release
> 
> Now clean, build, test and use "hg bisect good", "hg bisect
> bad" or "hg
> bisect next" as needed; stop when it says that the bad
> revision has been
> found.
> 

Okay, I will try to do that soon. I have never used hg before,
so there is a learning curve. I was hoping that the author of
the change (Claudio Ciccani: kl...@di...) would be able to
determine what broke from the data I have gathered. The problem
is clearly in demux_flv.c, but it is not a trivial fix for me
since the entire file has been rewritten.

I also noticed that going back to the version of this file in
1.1.4 breaks sound for flash video although it fixes the problem
of playing them from stdin or http, so the fix really needs to
be in the current version.


> > There appear to be multiple problems in demuxers/demux_flv.c
> - I
> > was able to fix one of them, but I am stumped on another.
> There
> >  is a bug in the block of code at line 186.
> 
> > demux_flv.c: 186
> 
> >   if (INPUT_IS_SEEKABLE(this->input))
> >     this->input->seek(this->input, this->start, SEEK_SET);
> >   else if (this->start > 9)
> >     this->input->seek(this->input, this->start-9, SEEK_CUR);
> 
> > The fix is to add the following code to the above
> conditions:
> 
> >   else if (this->start == 9)
> >     this->input->seek(this->input, 9, SEEK_CUR);
> 
> Testing for this->start >= 9 would seem to be more
> appropriate.
> 

No, the seek amounts for (this->start == 9) and (this->start >
9) are different in the existing code.

    ---Akmal



__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com