[xine-devel] Fwd: Re: [Kaffeine-devel] screenshot: return only visible part of the image

[Christoph P. <chr...@gm...>]

Hi,

Taking snapshots from some videos leads to incorrect results because the im=
age=20
has to be clipped (see the three links below - confirmed over here with=20
pretty recent 1.2hg).

Just to make aware you of this issue ... :)

Christoph


=2D---------  Weitergeleitete Nachricht  ----------

Subject: Re: [Kaffeine-devel] screenshot: return only visible part of the=20
image
Date: Samstag, 23. Juni 2007 17:42
=46rom: kd...@vo...
To: Christoph Pfister <chr...@gm...>

Hallo Christoph,

unter

http://www.vogtner.de/si/screenshot-issue.mpg
http://www.vogtner.de/si/screenshot-ist.png
http://www.vogtner.de/si/screenshot-soll.png

findest du den Testfall. Ich benutze xine-lib-1.1.6.

Viele Gr=FC=DFe

Stefan

Christoph Pfister schrieb:
> Hi,
>
> 2007/6/17, kd...@vo... <kd...@vo...>:
>> If kaffeine renders a video with w x h samples and w or h is not an
>> integer multiple of 16 the xine engine seems to round the value to the
>> next integer multiple of 16 greater than the value before scaling.
>
> I don't have this behaviour over here (a screenshot of 349x240 movie
> gives an image with that size).
> Which version of xine-lib are you using? Do you have a sample to test tha=
t?
>
>> Example: 660 x 528 samples per image.
>> destination frame aspect ratio is 4:3
>> video aspect ratio is 528*4/3*660 =3D 1.0666667
>>
>> video data size: 660 x 528        -- x 1.066667 -->  704 x 528 (4:3)
>> rounded        : 672 x 528
>>
>>
>>              x 1.0666667
>>
>>                   V
>> scaled         : 717 x 528
>> cropped to     : 704 x 528 (this is displayed)
>>
>> However, the kaffeine-screenshot returns the full uncropped image of
>> size 717 x 528 containg 13 x 528 pixels of garbage.
>>
>> The enclosed patch performs the required cropping.
>>
>> --
>> Stefan
>
> Christoph

=2D------------------------------------------------------