From: Stas S. <st...@ak...> - 2007-05-24 18:19:58
|
Hi. Hans-Dieter Kosch wrote: > I suggested this conditional to prevent asynchronously mixed output > because of independent buffering in the separate streams. Yes, I see. OK, in this case I'll weight the amount of work needed to get the debug output to stderr entirely. Doesn't look like too much in fact. :) For some reasons the code flow dependancy on a verbosity level, gives a rather large penalty to the proposed approach in my eyes. >> And IIRC xine-ui forgets to use -g flag when >> you specify --enable-debug. > This depends if we only want DEBUG defined or also have gdb info, but it > seems reasonable to have the -g flag. Attached is the patch that does this. I also removed NDEBUG - it seems to be unused, and even if not - the one should just use "#ifndef DEBUG" instead IMHO. |