Re: [xine-devel] Xine CD playback patches; please review

[Darren S. <li...@yo...>]

I demand that Christopher Martin may or may not have written...

> On Friday 07 July 2006 18:17, Darren Salt wrote:
>> I demand that Christopher Martin may or may not have written...
>>> I'm trying to have some Xine patches reviewed and committed:
>>> http://sourceforge.net/mailarchive/forum.php?thread_id=9841180&forum_id=7131
>>> http://sourceforge.net/mailarchive/forum.php?thread_id=12120153&forum_id=7131
[note: brokenly-wrapped URLs fixed]
>> The larger of the two is now in CVS. As for the other, have you tried
>> other values for CACHED_FRAMES?

> Yes, I experimented with various values for a while, testing Xine on the
> various drives around the house. 500 fixed the 'audible gap' problem for
> all the reasonably modern drives. Less than 500 resulted in occasional gaps
> still being audible.

Fair enough.

> One ancient drive still didn't play without gaps even at 500, but a value
> far, far greater than 500 would have been needed to fix that drive, judging
> from the remarkable length of the audible gaps. So I concluded that 500 was
> a reasonable value that would cover the problem for the vast majority of
> people and drives.

If it happens that there are many more drives which do that *or* there are
many drives for which 100 (or some other value significantly less than 500)
works well, it might be worth turning this constant into a configurable
option...

Committed as is for now.

[advert removed - use a .sig separator so that it can happen automatically]

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
|   Say NO to UK ID cards. http://www.no2id.net/

No analysis is a complete failure - it can always serve as a bad example.