Re: [xine-devel] Greedy2Frame deinterlacing and disabled MMX & SSE optimizations on x86-64

[Niko M. <nm...@ph...>]

On Sat, 4 Feb 2006 13:30:05 +0000
Miguel Freitas <mfr...@gm...> wrote:

> On 12/28/05, Niko Mikkila <nm...@ph...> wrote:
> > > I was trying to get Greedy2Frame and TomsMoComp deinterlacing to work
> > > on my 64-bit Debian unstable setup and xine-lib from CVS, but it turn=
ed
> > > out that they couldn't even be selected as tvtime methods. That's
> > > because they need MMX or SSE support and those CPU features were not
> > > marked as available by xine_mm_accel in xine-lib/src/xine-utils/cpude=
tect.c.
> > > In case this is not intentional, and to show you what I'm talking abo=
ut,
> > > I attached a patch that enables these features on x86-64 (=3Damd64).
> > >
> > > [...]
> >
> > Replying myself because I just noticed that there was already
> > a thorough patch submitted in November by dani3l, but apparently it
> > hasn't been noticed so far:
> > http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D1354484&gr=
oup_id=3D9655&atid=3D109655
> >
> > Any chance of getting this applied?
>=20
> i usually don't feel comfortable committing patches that i can't test.
> your report of non-working Greedy2Frame stuff also worries me... why
> should we enable something that doesn't work for x86-64 users?
>=20
> i will take a look on both patches and maybe apply some parts.
> hopefuly amd64 users will complain in case it breaks something ;-)


Hi Miguel,

Greedy2Frame now works with dani3ls patch, and also does with the Xine
CVS. I happened to update to the latest CVS on Saturday night, and was
surprised to find the changes already in place :)

However, there is a problem with the version of libavcodec used. First,
when compiling, it seems to break (if I recall correctly) because you
left HAVE_MMX disabled in dsputil.h for x86-64. When I enable that,
libavcodec can't be built because of some register problems in inline
assembly. I had the same problem a month ago when I last tried this,
but of course I forgot to report it here. Anyway, I thought fixing that
would require untrivial changes all over the place, so I updated the
whole "libffmpeg" from ffmpeg CVS and applied the Xine patches on it.
That seemed to help so that I was able to build libffmpeg and then Xine
without problems. I haven't done any extensive testing, but so far it
has worked fine for me.

Updating libffmpeg is not a small patch, so do you have some
established guidelines on how to do it? Does someone maintain that
part of the Xine source tree and update it every now and then?

--
Niko Mikkil=E4