From: Miguel F. <mfr...@gm...> - 2005-09-24 21:45:55
|
On 7/29/05, Jason Tackaberry <ta...@sa...> wrote: > On Fri, 2005-07-29 at 13:22 -0300, Miguel Freitas wrote: > > > every frame disposes and reallocates/attaches an X shmem buffer. Now= , > > > malloc()/free() is very fast, but I think the overhead for all the sh= mem > > > and Xlib calls is probably less trivial. > > > > right. it would be very interesting to benchmark this. > > i mean, it seems like a good optimization to me. we should not > > maintain 2 different fifos in video_out (we don't know how many > > different formats are being used by decoders and post plugins) but > > rather priorizing frames with the same format when trying to allocate > > a new frame from the fifo. > > I guess in that case it's not a fifo anymore, strictly speaking. :) But > yes, that kind of optimization doesn't sound complicated, and done at > that level, all video outs would benefit from it, plus it won't increase > memory usage either. what you would say if i tell you this optimization reduced cpu usage here in 20-25% while using deinterlacing plugin in film mode? it did! ;-) i guess i will commit the (experimental) optimization and let people test / report any issues... Miguel |