Re: [xine-devel] files empty

[Bastien N. <ha...@ha...>]

On Tue, 2005-07-26 at 14:11 +0200, Michael Roitzsch wrote:
> Hi Bastien,
> 
> >> What happened here is the new warning on empty files, which got
> >> introduced in the input plugin in revision 1.101. Here is the patch:
> >> http://cvs.sourceforge.net/viewcvs.py/xine/xine-lib/src/input/
> >> input_file.c?r1=1.100&r2=1.101
> >>
> >> Before this, xine might have silently skipped empty files (depending
> >> on the type). So I guess these files have been empty all along, but
> >> now with the new warning, xine came to realize it.
> >
> > Actually, before that, we would get an error message saying that we
> > couldn't find a demuxer for it.
> 
> Have you tried that? I have not, but the MP3 demuxer  
> (demux_mpgaudio.c) seems to accept any file with the correct .mp3  
> extension in METHOD_BY_EXTENSION without any further checks. I guess  
> it would accept an empty file with a .mp3 extension without a "no  
> demuxer" error.
> 
> Of course this is very different for other formats with more pickier  
> demuxers.

Very possible indeed. I don't remember what I tried it with. Anyway, I
think telling the front-end that the file is empty is better than some
non-obvious error about missing decoders/demuxers or 0-length files.

---
Bastien Nocera <ha...@ha...> 
I'm sorry if they don't like it. They should go back and see The Matrix
or something. -- George Lucas (on Episode I)