[xine-devel] Re: release done / problems in libvcd, win32

[R. B. <ro...@pa...>]

Sorry I didn't see this sooner...

Michael Roitzsch relates: 

   The file xine-lib/src/input/vcd/libvcd/version.h is not included in the
   release. This is not a problem, because the file is not used anywhere, so
   it appears to be obsolete. 

Inside version.h, LIBVCD_VERSION_NUM is #defined. LIBVCD_VERSION_NUM
is like INPUT_PLUGIN_IFACE_VERSION - it allows VCD player code to work
with both newer and older libvcdinfo features. It may not be used
currently, but it has in the past and may in the future since
libvcdinfo is still missing some VCD capabilities. In this sense I
don't think version.h is obsolete.

   However, the libvcd version number in the file
   is correct, while the one in the file that is actually used (which is
   xine-lib/src/input/vcd/libvcd/libvcd/version.h) is older.
   Could the libvcd expert please clear this up?

My guess is xine-lib/src/input/vcd/libvcd/version.h should be moved to
xine-lib/src/input/vcd/libvcd/libvcd/version.h. 

The problem with this subset of libcdio and vcdimager is that neither
subset is organized like any of the existing or past vcdimager and
libcdio distributions. For example, in vcdimager that version.h is
generated via configure, but there is no configure here. 

The promoters of this organization aren't maintaining it and really
haven't been for a long while. Personally I'd like again to suggest
that libcdio and vcdimager just be a requirement or you get the old
VCD plugin. Alternatively one of the proponents of the current
approach (cut and paste and subset and modify) could maintain the
subset better.