Re: [xine-devel] DVD misc

[Michael R. <mr...@us...>]

Hi,

> > I think we all agree on this :)  Here's the definition of the new event
> > type and the associated data structure.  Can somebody add this to
> > xine.h.in and commit?  I will post a patch to input_dvd.c shortly.
>
> looks good to me. i guess we may commit it as soon as you send us the
> complete patch (unless, of course, anybody objects...)

Just a thought from me: I would like some additional sanity checking for 
certain special cases. Example: We generally want to allow arbitrary seeking 
and skipping, but we may want to deny it, if there are cell commands, because 
skipping over those can move the VM into a bad state.

Unfortunately, this information is not available to frontends, so the frontend 
might not be the best place to make such decisions.

I would still prefer a configurable restriction level in libdvdnav, which 
specifies, how much restriction you want to follow. But this can be done in 
addition to the current event solution, which would still be needed to 
enable/disable the corresponding UI elements.

It's just that I would like to move the actual enforcing of the restrictions 
into libdvdnav, because it is common code and libdvdnav has more context 
knowledge to make smarter decisions.

Michael

-- 
/* When we have more time, we can teach the penguin to say 
 * "By your command" or "Activating turbo boost, Michael".
 */
	2.2.16 /usr/src/linux/arch/sparc/prom/sun4prom.c