Re: [xine-devel] Xine Free Type support

[Andreas <and...@we...>]

Am Dienstag, 25. Januar 2005 02:02 schrieb Stefan Holst:
> hallo andreas,
>
> Andreas R=F6ver wrote:
> >>committed your fixes to cvs after correcting some typos.
> >>thanks again, very nice work. :)
> >
> > Thanks,
> >
> > but I am sorry to inform you that I found a bug in my code. I have not
> > used the right fields for the height and ascender. I have used values
> > that are not dependend on the font size. These are replaced in the
> > appended patch. I have also done a few more things:
> >
> > - clip the clip area really to the valid range and not only relativ to
> > the lower right edge. This is necessary if you place text with negative=
 x
> > or y coordinate.
> >
> > - simplify the per pixel check when drawing the glyphs. I do now assume
> > that the currently drawn to line in the osd is completely available but=
 I
> > do correctly clip the left and right edges. The check for the y position
> > is only performed once per line
> >
> > - I have done the same changes to the normal xine fonts
> >
> > - replace all occurences of ">>6" with "/64" as we dont really know if
> > the values can not be negative and the shift operator is not defined to
> > behave correctly with negative values
> >
> > - assign the height value only once for true type fonts.
> >
> > Andreas
>
> sorry, this patch segfaults here, if text is rendered to the lower-right
> corner of the video (clipping test). i have no time to debug this right
> now and you sure know the code better than me ;)

Indeed, when the whole string is placed blow the osd then it segfaults. The=
=20
new version of the patch should fix that.

> with this interactive ruby session, a window opens and osd are drawn
> into it on o.show. the session above triggers also another bug with
> freetype: the text only appears after drawing the point. so the osd
> is not properly increased by the ft2-text rendering.

This seems to be no problem with my version of the lib. I don't know whats=
=20
wrong here.

Andreas