From: Andreas <and...@we...> - 2005-01-16 12:31:55
|
Hi, I've had a few problems with the free type support in xine, so I put together a patch fixing a few problems: - Fix pixels not belonging to font. The current implementation makes these to the background color of the font, but I think this is not right. They should be left untouched just as in the other font routine - Add Kerning support - Fix bug with clipping. The current implementation will segfault, when the text reaches ABOVE the overlay. I've also corrected the behaviour when the text leaves the left or right border of the overlay. - A bit of cleanup There are a few problems left with FT support: The main is the calculation of the text size. It currently calculates the hight above the baseline instead of the real hight. The problem is that glyphs can only be placed relative to the base line so the given coordinate is the left point on the baseline of the first letter drawn. The only solution to this problem that I could find is to add another parameter to the xine_osd_get_text_size function returning the "maximum depth" below the base line. This value is always 0 for xine fonts and only calculated when a valid pointer is given. This way the old behaviour is still available. Is it ok to implement something like this and change the interface (or add another function) Another problem is the border, but that's a minor one... Anyway here is the patch Andreas |