Re: [xine-devel] Re: [xine-user] [remote] [control] xine-lib open_aiff_file overflows buffer

[Michael R. <mr...@us...>]

Hi Mike,

> > We should apply your logic to the input tree too, we have exactly the
> > same kind of problem here.
>
> 	Done. I did not find any problems during my quick, cursory
> investigation. To be clear, I do not investigate every byte array. Many
> declarations take the form of "unsigned char buffer[FILE_HEADER_SIZE];".
> I know the way I code and I know that in those cases, I read in
> FILE_HEADER_SIZE bytes. Also, I did not follow up on sizes that were,
> e.g., 4, 8, 12, or 16. I would not expect that the author would store
> arbitrary-length data in those.

It is perfectly clear that we cannot find every bug by auditing. Some just 
have to be found by chance. But those little tests for similar problems once 
one has shown is definitely a good thing. Thanks for your efforts.

Michael

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds