Re: [xine-devel] buffered input plugin layer

[Thibaut M. <thi...@gm...>]

Hi Miguel,

On Tue, 26 Oct 2004 14:56:15 -0200, Miguel Freitas <mfr...@gm...> wrote:
> On Tue, 26 Oct 2004 13:46:25 +0200, Thibaut Mattern
> <thi...@gm...> wrote:
> > It would be cool if someone has time to quickly review the code, the
> > testsuite will tell if it's buggy, but a code review can detect crappy
> > code or design problems.
> 
> i believe i've fixed some issues, do you want to double check?

ok

> i'm attaching my changes (some are just casts to avoid loudy compilers, if any).

thanks for your fixes, everything looks ok.
 
> is it ok to call it "input_cache" instead of "input_buf"? i'm asking
> because i think we have far too many things named "buf" and cache
> should be better. i also added a new option "#nocache" that prevents
> this plugin from being used.

no problem. feel free to commit, i can't do that right now.
#nocache is a good idea, it will be easy to test if this plugin
improves playback with gnome_vfs or other slow input plugins.

> regards,
> 
> Miguel

Thibaut