Re: Re: [xine-devel] FIX: libmpeg2 sets wrong (mpeg1) aspect ratio for mpeg2 str

[Thibaut <tma...@no...>]

Hi Michael,

----Message d'origine----
>De: Michael Roitzsch <mroi=40users.sourceforge.net>
>A: xine-devel=40lists.sourceforge.net
>Sujet: Re: =5Bxine-devel=5D FIX: libmpeg2 sets wrong (mpeg1) aspect ratio=
 for mpeg2 streams
>Date: Thu, 16 Sep 2004 15:19:50 +0200
>Copie =E0: Thibaut <tmattern=40noos.fr>
>
>Hi Thibaut,
>
>> There is a problem because a frame format event is sent when a sequence
>> header is parsed, and at this time you don't know if it's mpeg1 or mpeg=
2
>> sequence and the default value is used.
>=5Bsnip=5D
>> Question for engine guys, why is this event sent by decoders ?
>> The information is not in sync with the output, and we have to duplicat=
e
>> this code to other decoders. IMHO it would be better to do this kind of
>> stuff in the output loop.
>
>This event is used by some SPU decoders (currently the DXR3's and spucc, =

>spucmml also intercepts the event but does not react on it yet) who need =
to =

>know about the image dimensions and/or aspect information the video decod=
er =

>is currently using.

ok

>Of course these SPU decoders could use the video out info instead (in fac=
t, =

>sputext does that), but I think this is wrong, since this information is =

>delayed by the length of the video fifo and might be outdated.

Ok, i thought this event was also used by frontends.
If the event has to be sent at decoding time, why not moving the image dim=
ensions and/or aspect information change detection to the vo=5Fframe=5Fdra=
w function ?

>Michael
>
>-- =

>printk(KERN=5FWARNING =22%s: Short circuit detected on the lobe=5Cn=22,
>dev->name);
>	2.4.0-test2 /usr/src/linux/drivers/net/tokenring/lanstreamer.c

Thibaut