[xine-devel] Re: Cropping (was: Several bugs)

[Miguel F. <mfr...@gm...>]

Hi James,

On Sat, 28 Aug 2004 14:44:34 +0100, James Stembridge
<jst...@fa...> wrote:
> On Friday 27 Aug 2004 22:50, Miguel Freitas wrote:
> > i guess we need to extend vo_frame_s to include cropping information,
> > such as display_width, display_height, display_offsetx,
> > display_offsety. opinions?
> 
> As it would happen I've implemented this before :)
> 
> http://thread.gmane.org/gmane.comp.video.xine.devel/8394


As it would happen your patch is clear and concise, very nice work :)


We still need to work out xshm issues. Your idea of delaying
dest_size_cb() call to the first proc_slice is great. We have
absolutely no need to allocate the rgb ximage at get_frame time, we
just need to set the the yuv buffer so the decoder can proceed.

Besides, I'm still not entirely convinced we can't get away with the
xshm cropping by just tricking yuv2rgb converter to skip some
lines/pixels...

regards,

Miguel