From: <va...@us...> - 2004-09-02 20:01:05
|
Hi team, V =C3=9At, 31. 08. 2004 v 23:16, Michael Roitzsch p=C3=AD=C5=A1e: > > I have one janitorial duty I would like people to do. Can people doub= le > > check their code and remove any compiler warnings? I got a nice long > > this when I did a build last night. I collected them by doing "make | > > grep warn". This item was on the list of things to be done for this > > release in the TODO file. >=20 > I regularly do a "make clean all install 2> warnings.log" and check the= log. > All warnings listed there are either unfixable right now (libtool and a= utomake=20 > warnings) or are in non-xine code (vidix is the most prominent one here= ).=20 > With my compiler (gcc 3.3.2), I get no warnings in native xine code and= only=20 > a few in total. I think we can consider the warning item done. >=20 What about warning "use of cast expressions as lvalues is deprecated"? I guess it's in category 'unfixable right now'. I fixed several warnings on WIN32 platform, but some remain. One is due to GUID - WIN32 API has non-portable GUID struct (using unsigned long instead uint32_t) which cause one warning in demux_asf.c. I would let it there. And more important: We print file offsets (off_t) and thread (pthread_t), so maybe we would need some formating string for it. off_t differs on various systems and configurations and in MINGW32 it's only 32-bit. Cheers, Frantisek |