Re: [xine-devel] New image format - black menus.

[<uni...@sh...>]

Hi!
Thanks for your swift reply.

Michael Roitzsch wrote:

>Hi Thomas,
>
>  
>
>>While finishing up a xine-plugin for the unichrome XvMC extension
>>(basically VIA's HW mpeg2 decoder)
>>    
>>
>
>Nice project! :)
>
>  
>
>>I've noticed that when menus are displayed and a new menu item is selected, 
>>the screen goes black. 
>>    
>>
>
>What menus are we talking about? DVD menus?
>
>  
>
Yes, exactly.

>>The output plugin seems to be requested to display a frame which basically
>>is black, and that probably has been decoded before and placed in the
>>output queue.
>>
>>The same thing happens if I introduce the new image format in libmpeg2 and
>>video_out_xv, but let these plugins follow the same codepath as with the
>>XINE_IMGFMT_YV12 format , I.e: I replace all
>>
>>case XINE_IMGFMT_YV12:
>>...
>>
>>with
>>
>>case XINE_IMGFMT_YV12:
>>case XINE_IMGFMT_MY_NEW_FORMAT:
>>...
>>
>>in what seems to be all relevant places, and also make the new format
>>identical to YV12.
>>
>>Otherwise everything seems to work very nicely. Overlays are displayed as
>>they should either through X11osd or HW XvMC subpictures.
>>
>>Does anybody have a hint as to where to start digging?
>>    
>>
>
>Have you looked at xine-lib/src/xine-engine/video_out.c, lines 265ff and 
>594ff? What you describe (if you mean DVD menus) sounds like the frame 
>duplication does not work.
>
>It is a known problem that xine is limited when it comes to new frame formats.
>We expect some changes there after 1.0 final is out.
>
>  
>
Yes, this was indeed the problem. More specifically the 
duplicate_frame() function
only seems to support YV12 and YUY2 formats. I assume the vo_frame_t 
class needs a
proc_duplicate_frame_data() method? Which might not be implemented in 
the near future?

Is there some way to use proc_frame() for this? Any other suggestions?

Regards,

Thomas