From: Michael R. <mr...@us...> - 2004-07-23 13:52:02
|
Hi, > > But I am seriously thinking about some string or array classes for post > > 1.0... Any opinions from others about this? > > just to make sure we don't reinvent the wheel (again): we already have > some safe buffer and string manipulation functions at xine_buffer.h. > they implement dynamically growing buffers and size checking. they are > mainly used in real rtsp plugin, but we can of course use it in all > xinelib modules. > > it took me a while to get used, but thanks to some macros that take > care of updating the buffer pointer, it is quite handy. This looks very similar to what I thought about. I remember having seen these functions before, but it seems I did not understood their importance. I think most of xine's string handling should be ported to use these functions. Question is, how should we proceed? a) Drop reviewing all string functions and port things right away. b) Complete the review, leaving the ugly C-string functions and fixed-size arrays in there and port things slowly over time. What do you think? Btw, part of my ignorance concerning these functions might be due to their name. When I hear "buffer" in xine, I think of something else. Maybe xine_array_* is a better name? Michael -- /* James M doesn't say fuck enough. */ 2.4.3 linux/net/core/netfilter.c |