From: Mike L. <mik...@ho...> - 2004-04-15 16:24:01
|
hey Michael, All, >From: Michael Roitzsch <mr...@us...> <snip> > > and the logic in line 385 was always 1 which stopped the plugin from > > reverting to non-panscan mode if the stream stopped supplying panscan >info. > >If I get it right, you changed the (this->panscan_smart_change || >this->afd_smart_change) to (this->panscan_smart_change > 0 || >this->afd_smart_change > 0), right? Do you mean these smart_change values >can >get negative? I don't see how this could happen. Otherwise, both >expressions >should be equivalent. Have I overlooked something? the smart_change variables initially are 0, and if panscan info is present, these variables are set to 25 and decremented over time, so if a stream _had_ panscan data but its no longer present (or never was) then yes, these vars will decrement below 0 .. I think in my inital patch I had a failsafe if(panscan_smartchange<0) panscan_smartchange=0; or something similar.... after some fairly exhaustive testing here, I would recomment that the smartchange vars be set to 50 rather than 25, as some streams are a bit lax in updating these descriptors.... > > > Therefore, when navigating in such a menu with the mouse using >letterboxed > > > overlay, the button highlight areas sensitive to the mouse should be >wrong > > > (they should be shifted in x direction towards the center). Can you > > > confirm this? Does the attached patch fix this? > > > > the patch corrects this, and mouse-overs are now spot on. > >This is in CVS now. groovy... Regards Mike _________________________________________________________________ You could be a genius! Find out by taking the IQ Test 2003. $5.50 (incl GST). Click here: http://sites.ninemsn.com.au/minisite/testaustralia/ |