Re: [xine-cvs] CVS: xine-lib/src/libffmpeg video_decoder.c,1.32,1.33

[James S. <jst...@gm...>]

Hi Thibaut,

On Mon, 20 Sep 2004 15:52:07 -0700, Thibaut Mattern
<tma...@us...> wrote:
> Do never memcpy the buffer if the stream is mpeg1/2.
> See why it's not needed in mpeg_parser.c
> 
> This fixes mpeg-es playback, especially xine-ui logo playback ! ;)

Can we guarantee that this:

((buf->size + FF_INPUT_BUFFER_PADDING_SIZE) < buf->max_size)

condition will always be true for mpeg-es playback? Otherwise the
ffmpeg bitstream reading code can overrun the buffer and cause a
segfault.

James.