From: Bastien N. <ha...@ha...> - 2003-12-25 00:51:56
|
On Thu, 2003-12-25 at 00:49, Daniel Caujolle-Bert wrote: > Le jeu 25/12/2003 à 01:36, Bastien Nocera a écrit : > > On Thu, 2003-12-25 at 00:29, Siggi Langauf wrote: > > > Hi, > > > > > > with the quite important fixes we have in CVS (NPTL audio thread > > > starvation, for example) and the API incompatibility introduced by > > > increasing XINE_LANG_MAX, xine-lib 1-rc4 should be released ASAP. > > > > > > I'd suggest reducing XINE_LANG_MAX back to 32, even if that means that he > > > ogm demuxer has to shorten ultra-long language labels to 31 characters. > > > Alternatively, we can have libtool switch to libxine.so.2, introducing an > > > officially incompatible API. > > > > It doesn't change the API, and when it used to crash, it will keep on > > crashing (ie. you only need to recompile the front-end if you want it to > > stop crashing). > >It does *not* require the recompilation of front-ends (but it is > > recommended to), and doesn't change the ABI either. > > Beg your pardon ? This is a breakage, frontend using this constant (32) > value will crash, and recompilation isn't a clean solution (i mean, for > people who simply use binary packages). I suggest, like Siggi, to > release a rc4 now with a 32 value, and rc5 will will have 128 length > with a libtool API version change. I'd like you to show me the crash... They will crash for subchannels with a length > 32 chars, which was the reason for them crashing in the first place. They will only crash as they used to. Any ABI version bump is gratuitous. --- Bastien Nocera <ha...@ha...> Remember that age and treachery will always triumph over youth and ability. |