Re: [xine-devel] Re: Merging xine-vcdx into xine-lib xineplug_inp_cd.c,1.38,1.39 xineplug_inp_vcd.c,1.100,1.101

[Daniel Caujolle-B. <seg...@cl...>]

Le jeu 09/10/2003 =E0 20:28, Miguel Freitas a =E9crit :
> On Thu, 2003-10-09 at 09:21, R. Bernstein wrote:
> > In your last message, you suggested the question of whether to have
> > vcdx and cdx in addition to vcd and cd was related to whether we have=
 a
> > portion of libcdio and vcdimager inside xine-lib or it live outside.
>=20
> obviously, that's just my opinion, not something written at the stone..=
.
>=20
> > I'd prefer not having a portion of libcdio and vcdimager (and possibl=
y
> > libcddb) inside xine-lib. I don't have the slightest problem with
> > having both sets plugins available simultaneously or configurable so
> > that folks can choose what they want. So let's go that way.
>=20
> that's fine with me, what do other developers think?
>=20
> i must say i like the idea of having only one (navigation capable) vcd
> plugin that works "out of the box" (including libcdio and libvcdinfo).
> it is a similar decision to what we did in the past for the dvd plugin
> that turned to be very good imho.
>=20

	If xine-lib will ship those plugins, we HAVE to do the same way as
dvdnav. External dependencies are borring, and even more, users will
"flame" us because they can't get their CD or VCD playable with xine.
	This way, i bet we will get an extra amoung of support request in the
-user list.

> > So when you get a binary package from one of these
> > fine people, not only have they done the work to strip out the stuff
> > you don't absolutely need like source code and regression-test code,
> > but they have also tested things for you. Not so when this is part of
> > xine-lib. At least not yet!
>=20
> as xine project does not provide any binary packages, we can either:
>=20
> 1) ship xine with test streams and regression test scripts
> 2) test multiple streams, in different systems, and hope that other
> compilers won't break our code. fix the problems as they are reported.
>=20
> i believe providing regression tests to the entire xine-lib to be
> completely unfeasible. we support a LOT of formats, having test streams
> for all of them within the tarball is not possible.
>=20
> so we have being doing (2) and so far it seems to be working fine. i
> don't think we would have any problems including libcdio without the
> regression tests. of course we would test any updated version the same
> way we currently do with ffmpeg, for example.

	I agree. The xine's 1st rule is "made the user's live easy as
possible".

>=20
>=20
> > Another problem of having a piece of one of these other packages
> > inside xine-lib, whether I personally deal with keeping this in sync
> > or not, is that they *can* become out of sych. Someone will either
> > change the xine-lib code or there will be a bug fix in the outside
> > library code that doesn't get reflected in xine-lib.
>=20
> it doesn't have to be problematic as you say. i have a policy of not
> patching our local copies of external project unless strictly necessary
> (for example, if the maintainer of that project does not accept the
> patch). this is something quite rare, i always advice people to send
> patch to the original project (like faad, ffmpeg, etc).
>=20
> > Judging by the comment in
> > xine-lib/src/input/libdvdnav/WARNING_TO_DEVELOPERS, I think at least
> > James understands this problem. I'd prefer to avoid confusion by
> > simply making it impossible.
>=20
> we are not kids here, just agreeing to not patch our local copy should
> work. reverting the patch in case of any mistake is also easy, i can be
> responsible for syncing these libs if that bothers you.
>=20
> > As for the question of putting in vcdx but not cdx, to me it doesn't
> > make sense.
>=20
> i didn't said that. just that, given the dependencies and the ongoing
> discussion of merging external libs or not, i'd like to merge one plugi=
n
> at a time. that could be merging one today and the other tomorrow, or
> next week, etc. cdx might have it's own issues to be checked.
>=20

	And the current CDDA plugin can do already his job. xine can play CDs,
so that's fine for now.
	About VCD navigation, of course current vcd plugin didn't implement
that, so i think it's the first one which may be merged.

Cheers.
--=20
73's de Daniel "Der Schrecklich", F1RMB.

             -=3D- Daniel Caujolle-Bert -=3D- seg...@cl... -=
=3D-
                        -=3D- http://naboo.homelinux.org -=3D-