From: Miguel F. <mi...@ce...> - 2003-08-20 06:05:07
|
On Tue, 2003-08-19 at 14:09, Frantisek Dvorak wrote: > I made some changes yet: > > 1) removed using preview from input plugin (not a bug, only waste code: > reading preview data after get preview via get_optional_data isn't > needed) ok, i don't mind :) > 2) removed 'filename_stream' from 'rip_input_plugin_t', > pointer is valid only in 'get_instance' ok > 3) fix my bug in rip_plugin_read (it used data from preview when it > shouldn't) ? i believe you reverted some changes to rip_plugin_read_block. > 4) fix your bug in rip_plugin_seek (data wasn't saved during seeking on > block inputs) ? isn't this_gen->read_block the same as rip_plugin_read_block? whatever... > 5) used input plugin is writed into log, so I added also writing info > about rip plugin ok > 6) added using define RIP_ALWAYS_PERMIT, > Similar solution of legal/patent problem I've seen in freetype > library. > If you wouldn't like RIP_ALWAYS_PERMIT, feel free to remove it. removed. imho, user should be at least capable of understanding an "if" statement to unlock the rip plugin... :) well, here goes another round of patching... i basically did some changes at block read (not really tested) because old code doesn't seemed right. fell free to fix any mistakes. if none objects, something like that might find its way to cvs soon... :) regards, Miguel |