Re: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/xine-engine audio_out.c,1.121,1.122 configfile.h,1.19,1.20 load_plugins.c,1.147,1.148 metronom.h,1.44,1.45 osd.c,1.34,1.35 video_out.h,1.83,1.84 vo_scale.h,1.5,1.6

[James Courtier-D. <Ja...@su...>]

Thibaut Mattern wrote:

>Hi all,
>
>On Sunday 20 April 2003 23:13, Guenter Bartsch wrote:
>  
>
>>Update of /cvsroot/xine/xine-lib/src/xine-engine
>>In directory sc8-pr-cvs1:/tmp/cvs-serv28705/src/xine-engine
>>
>>Modified Files:
>>	audio_out.c configfile.h load_plugins.c metronom.h osd.c
>>	video_out.h vo_scale.h
>>Log Message:
>>merging in win32 port
>>
>>Index: metronom.h
>>===================================================================
>>RCS file: /cvsroot/xine/xine-lib/src/xine-engine/metronom.h,v
>>retrieving revision 1.44
>>retrieving revision 1.45
>>diff -u -r1.44 -r1.45
>>--- metronom.h	27 Mar 2003 18:57:08 -0000	1.44
>>+++ metronom.h	20 Apr 2003 21:13:23 -0000	1.45
>>@@ -39,6 +39,9 @@
>>  *    encoded streams.
>>  *
>>  */
>>+/* For the _MSC_VER (Win32) port the "this" variable
>>+ * was removed from all prototypes.and changed to "met"
>>+ */
>>    
>>
>
>WHAT ?
>what is this stupid "met" ?
>
>  
>
>> #ifndef HAVE_METRONOM_H
>> #define HAVE_METRONOM_H
>>@@ -79,7 +82,7 @@
>>    *
>>    * parameter pts_per_smpls : 1/90000 sec per 65536 samples
>>    */
>>-  void (*set_audio_rate) (metronom_t *this, int64_t pts_per_smpls);
>>+  void (*set_audio_rate) (metronom_t *, int64_t pts_per_smpls);
>>    
>>
I think that the standard used in xine is to replace "this" with "self", 
and not just a blank in all declarations that might be included if the 
application GUI is written in C++, but uses the xine-lib API .h files.
One should certainly not need to do this when compiling xine-lib because 
one should be using a C compiler for xine-lib and not a C++ compiler.

Cheers
James