From: Heiko S. <hsc...@ft...> - 2002-11-29 12:23:34
|
Hi Michael, thanks for the input, that's what i announced my change for. i was unsure what it could break, and apparently there is something. > > as far as i could tell, the previous implementation of this ADJ_VPTS > > branch in the code had no positive effects whatsoever. > > It had: it fixed dxr3 sync. (I'm still thanking Miguel for that.) So I > fear this is broken now, since the card does not like adjusting its > clock too much. But I will do some testing on this and report the > results. ok, that does it. i think it really makes sense (like miguel has suggested earlier) to give xine two behaviours for the user to choose from (via a config-setting): 1) the system clock is the master (i.e. no fiddling with the clock) - this was the behavious before my commit. that seems to be good for dxr3 users and generally for people who want absolutely smooth video playback at the price of possible audio glitches. 2) the audio clock is the master - that should be good for people who like the audio to be uninterrupted, no matter what. if the streams ptses are bad, then video playback will subordinate to the audio clock (i.e. video will be speeded up or slowed down a bit) ... or something similar. > There is one problem with the current solution, though: (Sorry for only > criticising your work, Heiko, but I had no problems with the past > solution, so I can only experience the bad effects. ;) oh, please criticise :) > Since we currently have only one global clock in xine, the current > method is problematic when playing multiple streams, because adjusting > the clock because of audio drift in ONE stream will affect ALL streams. i really do not understand that. i realize that there have been changes to allow for something called multiple streams, but i don't understand what the means. i was under the impression that this can be used for external subtitles and the likes. is that right ? > We have to find something better here. (Either for audio_out or for the > clocking strategy.) that's fine with me :) as long as my mpeg1 streams with slightly odd pts values will play back smoothly (without other stuff being broken, of course), i am happy ;) i'm looking forward to thoughts and suggestions. cheers, Heiko |