From: Miguel F. <mi...@ce...> - 2002-11-25 21:29:58
|
Hi Peter, On Mon, 2002-11-25 at 19:02, Peter Liljenberg wrote: > Hi, > > as part of porting dvbsub to 1.0 demux_ts.c, I've added > capabilites/optional data methods to the demux API. No need for panic > yet, I wont commit until after alpha2 has been released and tagged. > The methods are identical to the input API methods, and allow a > demuxer to provide the language information for audio and subtitling > streams. While DVDs store that information in the IFO file, separate > from the movie files, transport streams (and program streams too, > actually) contain that information in "descriptors" in the stream. > > This extension is used by xine_get_{spu,audio}_lang(), which will > first query the demuxer, then the input plugin. I don't expect this > to raise much controversy, as currently only the TS demuxer can > provide this information so for most of the content nothing changes. > All other demuxers have dummy methods that support no capabilities. I believe this is fine, just let me remind you of two points (from the above i guess you know them already): 1) since you are changing demuxer api, you must increase the version number at the corresponding header. 2) since old demuxers (with different version numbers) won't load anymore, it would be very nice if you could also update all other demuxers with your changes. (that is, provide the dummy methods) that's it. i just hope we can get a gpl'ed dvbsub decoder sometime! :) regards, Miguel |