Re: [xine-devel] [FIX] Volume control for aRts audio out plugin

[Miguel F. <mi...@ce...>]

Hi Igor,

On Wed, 2002-08-21 at 08:55, Igor Mokrushin wrote:
> I have made fix for Volume control for aRts audio out plugin. This patch 
> corrects a problem connected with a size of audio of the buffer more than 
> 16384 bytes. Excess of this size caused segfault. 
> This bug has been found out Christophe Lescane at playing AVI of a file 
> through win32 dll codec.
> -  ao_arts_volume(data, size / sizeof(short), this->mixer.vol_scale, this->mixer.vol_scale);
> +  ao_arts_volume(data, 8192, this->mixer.vol_scale, this->mixer.vol_scale);


May you elaborate more? i know you implemented software volume control
but i don't like commiting hardcoded stuff... ;)

Perhaps this segfault you've experience comes from one of the two
assumptions you do:

- 16 bits: it might be possible to pass 8 bit data to arts server, but
since i haven't exported the AO_CAP_8BITS capability here that should be
fine.

- stereo: you assume 2 channels at ao_arts_volume() which can obviously
be wrong (i've just played a mono stream using arts). very likely to
cause segfaults...

regards,

Miguel