Re: [xine-devel] Navigation comments

[Bill F. <bil...@mi...>]

On Fri, 12 Jul 2002, "R.J. Wareham" wrote:

> Bill Fink wrote:
> 
> > I sent in a patch a little while ago that basically does just that
> > for the dvdnav plugin, which I'm personally using and quite like the
> > new behavior of skipping by chapters.  I didn't know of any way of
> > testing if the input plugin supports chapters or their equivalents,
> > so it currently just checks that the input plugin is dvdnav before
> > changing the behavior.  However, I guess no one was interested in
> > submitting it to CVS or it just fell through the cracks.
> 
> The problem with the patch is that it hard-wires dvdnav-only support. 
> Perhaps the ability to check for chapter skip within the plugn via 
> 'get_optional_data' might be better? [I can certainly add support for 
> that in xine-dvdnav].

OK.  I tried changing the check I had in the gui_nextprev function in
xitk/actions.c from:

  if (gGui->skip_by_chapter && (strncmp(gGui->playlist[gGui->playlist_cur], "dvdnav", 6) == 0)) {

to:

  if (gGui->skip_by_chapter && (gGui->xine->cur_input_plugin->get_capabilities (gGui->xine->cur_input_plugin) & INPUT_CAP_CHAPTERS)) {

Unfortunately this doesn't work.  The get_capabilities function requires
an input_plugin_t * argument, but the xine entry in the gGui structure is
type xine_t which in the UI is defined as a void, so it's not possible to
reference the cur_input_plugin.

I can't figure out any way to access the cur_input_plugin from the UI.
Can anyone help me out here?

						-Thanks

						-Bill