Re: [xine-devel] Almost... Re: WORKING MPEG+SPUTEXT

[Boszormenyi Z. <zb...@ma...>]

Boszormenyi Zoltan wrote:

> The MPEG + SPU case works correctly for the time based SPUs, it seems
> correct on seeks. Does not work correctly for MPEG1 + frame based SPUs
> I have because that the SPU start and end frame counts seems to be wrong.
> It linearly slip, I tested with fast forward and seek.

If it wasn't clear enough, I have a time based and a frame based SPU
textfile for the same movie so I can compare them.
It works for the time based one, does not work for the frame based one
because as the time goes on, the subpicture appears more and more off time.

I tried the current CVS of MPlayer, it indeed works the same on this
movie with both SPU files as Xine with the posted patches.
As far as I can see, MPlayer goes off time with the frames based SPU exactly
where Xine with my modifications. So the frame based SPU I got
for this movie is wrong.

Now, I think it is enough proof that these patches are acceptable for Xine,
as well. ;-) <nudge> <nudge>

Now the only difference between the SPU displaying in Xine and MPlayer
is that MPlayer uses a fixed (pre-set) font size and it breaks lines by 
itself
where it sees fitting. This way, the subtitle is more consistently looking
that in Xine. Xine breaks line only where the subtitle says so and if
a line is too long, it decreases the font size. But it cannot decrease under
a certain font size and if a line is much too long, the subtitle wraps 
around
the right edge of the window and it overlaps the same line.
And if the subtitle contains line break, the different lines can have
different font sizes. Not very pleasant looking.

Best regards,
Zoltán Böszörményi