[ xcat-Bugs-3090498 ] Double $restab definition.

[SourceForge.net <no...@so...>]

Bugs item #3090498, was opened at 2010-10-19 12:57
Message generated for change (Settings changed) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1006945&aid=3090498&group_id=208749

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: SLES-specific
Group: 2.6
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Andrew Stepanov (st-an-v)
Assigned to: minjun xi (mxi1)
Summary: Double $restab definition.

Initial Comment:
Hello.

xCAT-server/lib/xcat/plugins/sles.pm


sub mknetboot
{

line 92:
    my $restab = xCAT::Table->new('noderes');

line 268:
    my $restab = xCAT::Table->new('noderes');

Please remove second definition.

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2010-11-18 08:20

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 28 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: minjun xi (mxi1)
Date: 2010-10-21 08:06

Message:
fixed in the svn trunk.

----------------------------------------------------------------------

Comment By: minjun xi (mxi1)
Date: 2010-10-21 08:06

Message:
yes, I added one TODO in the code, the table operations need to be moved
from the inner loop.

----------------------------------------------------------------------

Comment By: Bruce (bp-sawyers)
Date: 2010-10-19 15:40

Message:
>From looking at the code, it appears that this doesn't cause any problem,
it would just be a tiny bit more efficient to get a pointer to the table
once.  So I'm moving this to 2.6.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1006945&aid=3090498&group_id=208749