Re: [Xbae-discuss] more small patches

[Danny B. <dan...@pl...>]

Tobias,

The three patches are now applied, but the debugging check that
you describe below is disabled (it says "#if 1" now).

As for the dilemma : yes the meaning of visible_rows has been
unclear ever since I added variable heights, but in a number of
places in the code, an assumption such as the one you describe
was used.

My memory is a bit vague right now, but a small lookup in Macros.h
reveals that I defined SOME_ROW_HEIGHT to look up the height of
a specific row, where the old macro ROW_HEIGHT still exists for
places that require the default.

Their current definition :

#define ROW_HEIGHT(mw)  \
	(int)((TEXT_HEIGHT_OFFSET(mw) * 2) +   TEXT_HEIGHT(mw))
#define SOME_ROW_HEIGHT(mw, row) \
    (ROW_POSITION(mw, row + 1) - ROW_POSITION(mw, row))

Is this approach useful for doing something sensible with
visible_rows ?

	Danny

P.S. FYI the three patches were applied after creating the
  xbae-4.50.9801 version.

On Thu, 2004-09-16 at 01:05, Tobias Oed wrote:
> >From: Danny Backx <dan...@pl...>
> >To: Tobias Oed <tob...@ho...>
> >Subject: Re: [Xbae-discuss] more small patches
> >Date: Wed, 15 Sep 2004 00:05:44 +0200
> >
> >Looks like ROW_POSITION() is now checking whether the row
> >	mw->matrix.fixed_rows + mw->matrix.visible_rows
> >exists. Is this a valid requirement to make ?
> 
> Well, we're facing a dilema here. Since rows don't have the same height 
> anymore what
> value do we use for rows that don't exist ? Even the visible_rows resource 
> has a flaky
> meaning. Should this mean that the height in pixels should be set to the 
> height of the first
> visible_rows rows or to the average height of visible_rows rows?
> If we can agree on the average I can cook up a patch.
> Tobias.
> btw: The crash was triggered because checking got eanabled by the 
> fill+dead_space
> patch. Look for
> 
> #if 0 /* Wether or not to check each column_position access for debugging */
> #define COLUMN_POSITION(mw, column) mw->matrix.column_positions[column]
> #define ROW_POSITION(mw, row) mw->matrix.row_positions[row]
> #else
> #define COLUMN_POSITION(mw, column) xbaeCheckColumnPosition(mw, column)
> #define ROW_POSITION(mw, row) xbaeCheckRowPosition(mw, row)
> #endif
> 
> in Matrix.c. This checking slows things down a lot too.
> Tobias
> 
> _________________________________________________________________
> Dont just search. Find. Check out the new MSN Search! 
> http://search.msn.click-url.com/go/onm00200636ave/direct/01/
-- 
Danny Backx - danny.backx-at-planetinternet.be    http://up.to/danny.backx