From: F J F. <F.J...@sh...> - 2002-03-25 10:17:07
|
> Attached are the patches and the new files xml/wvXml.xml > xml/wvXml.dtd. Looks good for the most part. First a couple of minor points: 1. Usually best if you diff against AbiSuite's CVS wv since SourceForge CVS is often a little behind. 2. I take it you're building with auto* build system? Don't forget to make corresponding changes in Makefile.in etc. Question: You're adding " /" to close off tags in XML output, which is indeed necessary for XML, but is there any reason why we should not do this for Html and Wml as well? I know the later Html standards permit <img>, <br>, <hr> etc. to be closed similarly (<img />, <br />, <hr />) and, as far as I know, all browsers accept this, so... 3. Finally: wvConfig.c a. What is the purpose of this patch? b. Will it affect behaviour of other converters (wvHtml etc.)? c. You're opening an iconv stream, using it (properly?), *not* closing it... I'm not sure you want to be opening the iconv stream within this scope anyway, since it may be a performance hit. You will also run up against const-ness and other iconv bugs. If you really need to be using iconv then create a rigorous and persistent converter in text.c and call it from wvConfig.c if/when needed. Francis James Franklin F.J...@sh... "No, she really likes me. She told me I look like Britney Spears, and why would you say that to somebody you don't like?" --- Elle Woods |