Re: [Workrave-user] Workrave 1.4.0 on NT4 SP6

[Rob C. <ro...@kr...>]

> GUI::init_multihead() calls init_multihead_mem(1) when enum_monitors is
> NULL. However before making the call it sets num_heads to 1 which makes
> init_multihead_mem(1) effectively a nop.
>
> I believe the crash is caused because heads is never allocated
> (init_multihead_mem() would have done this if enum_monitors was not NULL).
>
> I think the line that sets num_heads should be removed (however I have
> only read three functions from the entire code base so I could easily be
> wrong).

Well spotted. I think you're right. I removed the assigmenent to num_heads. A new build
(pre3) is available at workrave.org/files. I've uploaded a version with and a version
without trace logging.

Many thanks!

Groetjes,
  Rob

-- 
Rob Caelers -- ro...@kr... or rob...@ph...
He that breaks a thing to find out what it is has left the
path of wisdom.    -- J.R.R. Tolkien