Re: [Wonder-disc] ERXCompilerProxy

[Tatsuya K. <tat...@ma...>]

Hi Anjo, 

These tips are great. Thank you.

>> if (currentDAHandler instanceof ERXDirectActionRequestHandler) ...
>>   handler = new ERXDirectActionRequestHandler(cacheEntry.className(),
>>                                                     "default", false)
> 
> This should probably use a class.forName() and a Method-based
> constructor - if one has too much time on his hands:) Then it would
> include the default handler as well.

I'm not under "having too much time" condition... but it's me who brought
the dependency. I'll try to update it later if nobody beats me.

Thanks, 
Tatsuya


>> ERXModelGroup.modelGroupForLoadedBundles()
> 
> This is a test, I'm not even sure it works reliably. It is supposed to
> clear the class cache of EOF and entice it to reload the classes. YMMV
> with that...
> 
>> ERXUtilities.booleanValueWithDefault(
>>     System.getProperty("er.extensions.ERXCompilerProxyEnabled"), false)
> 
> This can be replaced by
> 
>  
> "true".equals(System.getProperty("er.extensions.ERXCompilerProxyEnabled"
> ))
> 
> or simply left out.
> 
>> and also has:
>> 
>> if (currentDAHandler instanceof ERXDirectActionRequestHandler) ...
>>   handler = new ERXDirectActionRequestHandler(cacheEntry.className(),
>>                                                     "default", false)
> 
> This should probably use a class.forName() and a Method-based
> constructor - if one has too much time on his hands:) Then it would
> include the default handler as well.
> 
>> Also, I made up ERXCompilerProxyPrincipal class which registers an
>> observer
>> for ApplicationDidFinishLaunchingNotification and the observer invokes
>> ERXCompilerProxy.defaultProxy().initialize().
> 
> Actually, the compiler proxy itself can be used for that:) I once had a
> 
> static {
>   ERXCompilerProxy.defaultProxy().initialize();
> }
> 
> in there.