Re: [Wonder-disc] ERXMigration skipModelNames problem?

[Dennis B. <den...@xy...>]

Hi,

> I’m working on some migrations for other models and am finding that that model ends up in the migration queue even though it is listed in er.migration.skipModelNames

Do you happen to have dependencies between the models, i.e. modelB (which still should be migrated) uses entities from modelA (which is in skipModelNames)? We noticed that in these cases modelA will still be migrated as a dependency of modelB.

> Does anybody with more detailed knowledge of ERXMigrator see a problem with checking skipModelNames in _buildDependenciesForModel? It looks like that is the place where models are placed in the migrations map and it still works after I removed the other skipModelNames checks that I added in drilling through the stack traces. 

That is actually what we ended up doing as well. On the one hand now the property works as advertised, on the other hand you are always in danger of having migrated to the latest version of modelB which still will not work, because modelA is not up to date. Worse even, if they are sitting in the same database, migrations of modelB may fail because constraints cannot be set up properly. This change, while fine in certain circumstances, is possibly not good enough for a generic use-case because of these side-effects though? On the other hand, when you’re using skipModelNames you’re probably already somewhat aware, that you might run into issues if you’re not knowing exactly, what the specific migrations do...

Greetings
Dennis