From: Mike S. <ms...@us...> - 2007-02-27 12:28:43
|
Update of /cvsroot/wonder/Wonder/Common/Frameworks/ERExtensions/Sources/er/extensions In directory sc8-pr-cvs9.sourceforge.net:/tmp/cvs-serv7568/Sources/er/extensions Modified Files: ERXLogger.java ERXApplication.java Log Message: comment out the logging initialization exception and add a warning at startup when you run in development mode without WOAutoOpenBrowser = true Index: ERXLogger.java =================================================================== RCS file: /cvsroot/wonder/Wonder/Common/Frameworks/ERExtensions/Sources/er/extensions/ERXLogger.java,v retrieving revision 1.32 retrieving revision 1.33 diff -C2 -d -r1.32 -r1.33 *** ERXLogger.java 5 Feb 2007 21:26:53 -0000 1.32 --- ERXLogger.java 27 Feb 2007 12:28:32 -0000 1.33 *************** *** 187,191 **** log.debug("log4j.loggerFactory: " + System.getProperty("log4j.loggerFactory")); log.debug("Factory: " + factory); ! log.debug("", new RuntimeException("This is not a real exception. It is just to show you where logging was initialized.")); } //PropertyPrinter printer = new PropertyPrinter(new PrintWriter(System.out)); --- 187,193 ---- log.debug("log4j.loggerFactory: " + System.getProperty("log4j.loggerFactory")); log.debug("Factory: " + factory); ! // MS: This just trips everyone up, and it really seems to only be used by ! // PW developers, so I say we just turn it on when we need it. ! //log.debug("", new RuntimeException("This is not a real exception. It is just to show you where logging was initialized.")); } //PropertyPrinter printer = new PropertyPrinter(new PrintWriter(System.out)); Index: ERXApplication.java =================================================================== RCS file: /cvsroot/wonder/Wonder/Common/Frameworks/ERExtensions/Sources/er/extensions/ERXApplication.java,v retrieving revision 1.147 retrieving revision 1.148 diff -C2 -d -r1.147 -r1.148 *** ERXApplication.java 26 Feb 2007 10:08:35 -0000 1.147 --- ERXApplication.java 27 Feb 2007 12:28:32 -0000 1.148 *************** *** 575,578 **** --- 575,581 ---- public final void didFinishLaunching(NSNotification n) { didFinishLaunching(); + if (isDevelopmentMode() && !autoOpenInBrowser()) { + log.warn("You are running in development mode with WOAutoOpenInBrowser = false. No browser will open and it will look like the application is hung, but it's not. There's just not a browser opening automatically."); + } } |