From: Denis F. <de...@de...> - 2007-02-28 13:00:01
|
Hello Anjo, I have a question regarding your commit below. Are you sure that this change is appropriate? The reasons I'm asking are: 1. section() now returns different value for key of object, which means that all the projects that relied on "groupingKey" (e.g. had pages extending ERD2WGroupingListPage) key will stop work (this is something that happened with out projects). 2. "groupingKey" is used in ERD2WGroupingListXMLPageTemplate.java and ERD2WListXMLPage.java and d2wclientConfiguration.plist Most probably I'm missing the whole point of "groupingKey" and it's difference from "groupingItemKey". Can you please comment on this? Thanks, Denis. On Jan 15, 2007, at 5:29 PM, Anjo Krank wrote: > Update of /cvsroot/wonder/Wonder/Common/Frameworks/ERDirectToWeb/ > Sources/er/directtoweb > In directory sc8-pr-cvs9.sourceforge.net:/tmp/cvs-serv25418/Sources/ > er/directtoweb > > Modified Files: > ERD2WGroupingListPage.java > Log Message: > Was using the wrong key for grouping.... how could this ever have > worked?? > > Index: ERD2WGroupingListPage.java > =================================================================== > RCS file: /cvsroot/wonder/Wonder/Common/Frameworks/ERDirectToWeb/ > Sources/er/directtoweb/ERD2WGroupingListPage.java,v > retrieving revision 1.6 > retrieving revision 1.7 > diff -C2 -d -r1.6 -r1.7 > *** ERD2WGroupingListPage.java 20 Sep 2006 22:13:50 -0000 1.6 > --- ERD2WGroupingListPage.java 15 Jan 2007 14:29:34 -0000 1.7 > *************** > *** 24,28 **** > protected NSArray sublist; > protected Object sublistSection; > ! > // the sorting will come only from the rules > public boolean userPreferencesCanSpecifySorting() { > --- 24,28 ---- > protected NSArray sublist; > protected Object sublistSection; > ! > // the sorting will come only from the rules > public boolean userPreferencesCanSpecifySorting() { > *************** > *** 35,43 **** > return (String)d2wContext().valueForKey > ("groupingComponentName"); > } > public int colspanForNavBar() { > return 2*displayPropertyKeys().count()+2; > } > public Object section() { > ! return (Object)object().valueForKeyPath(groupingKey()); > } > public Object sumForSublist() { > --- 35,46 ---- > return (String)d2wContext().valueForKey > ("groupingComponentName"); > } > + public String groupingItemKey() { > + return (String)d2wContext().valueForKey("groupingItemKey"); > + } > public int colspanForNavBar() { > return 2*displayPropertyKeys().count()+2; > } > public Object section() { > ! return object().valueForKeyPath(groupingItemKey()); > } > public Object sumForSublist() { > > > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Wonder-cvs mailing list > Won...@li... > https://lists.sourceforge.net/lists/listinfo/wonder-cvs > > -- Denis Frolov Design Maximum MA Tel: +7 863 2648211 Fax: +7 863 2645229 Web: http://www.designmaximum.com |