[Wixedit-devel] [ wixedit-Bugs-1641756 ] Long names get whitespaces replaced with underscores
Project moved to Github: https://github.com/WixEdit/WixEdit
Brought to you by:
jaykee
From: SourceForge.net <no...@so...> - 2007-01-23 21:34:47
|
Bugs item #1641756, was opened at 2007-01-22 17:18 Message generated for change (Comment added) made by jaykee You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=726876&aid=1641756&group_id=133314 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Daniel Cazzulino (kzu) (dcazzulino) >Assigned to: Jasper Keuper (jaykee) Summary: Long names get whitespaces replaced with underscores Initial Comment: In WiX it's valid for long names to contain whitespaces in the name. The source code comment in the method that generates valid long names even acknowledges that. However, the regex used to perform the replace is the same one used in the generation of unique Ids, which matches whitespaces. This is incorrect and causes many manual edits to be required. ---------------------------------------------------------------------- >Comment By: Jasper Keuper (jaykee) Date: 2007-01-23 22:34 Message: Logged In: YES user_id=426742 Originator: NO Fixed in cvs will be in next release. (Fixed GenerateValidLongName, not replacing whitespace anymore. GenerateValidShortName now replaces whitespace instead of relying on GenerateValidLongName) Thanks for the clear report and patch! ---------------------------------------------------------------------- Comment By: Daniel Cazzulino (kzu) (dcazzulino) Date: 2007-01-22 17:47 Message: Logged In: YES user_id=222270 Originator: YES I also found that short name generation contains a bug, as it allows whitespaces. Last uploaded patch contains both fixes. File Added: FileImport.cs.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=726876&aid=1641756&group_id=133314 |