Menu
▾
▴
[Webware-devel] [ webware-Patches-678129 ] Report original exception for session unpickle error
|
From: SourceForge.net <no...@so...> - 2003-02-04 18:13:10
|
Patches item #678129, was opened at 2003-01-31 09:08 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=304866&aid=678129&group_id=4866 Category: WebKit Group: None Status: Open Resolution: None Priority: 5 Submitted By: Oleg Noga (oleg_noga) Assigned to: Stuart Donaldson (stuartd) Summary: Report original exception for session unpickle error Initial Comment: The purpose of this patch is to provide the original session unpickle exception instead of KeyError exception. --- Since we have no corrupted sessions on the disk, the Session KeyError is still appears. KeyError appears if SessionFileStore can't unpickle session while loading it from disk. Session can't be unpickled only if it has objects, with have buggy implemented unpickling feature. Developer, who works under webkit, would like to fix unpickling for his session. So, match better for developer to see the original exception instead of KeyError. --- This patch was made on Webware0.8b1. ---------------------------------------------------------------------- >Comment By: Geoff Talvola (gtalvola) Date: 2003-02-04 13:19 Message: Logged In: YES user_id=88162 I'm not sure it's a good idea to re-raise the unpickling exception here. It may be better to _print_ the unpickling exception and possibly email it to the administrator, but still raise KeyError so that the application can treat this as a missing session and possibly recover more gracefully. ---------------------------------------------------------------------- Comment By: Geoff Talvola (gtalvola) Date: 2003-02-04 13:16 Message: Logged In: YES user_id=88162 Wouldn't this part of the patch be easier if we just said "raise"? raise with no arguments re-raises the latest exception. There's no need to rebuild it from sys.exc_info(). + e = sys.exc_info() + raise e[0], e[1], e[2] # raise the exception again, so developers can look on it ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=304866&aid=678129&group_id=4866 |