[Webware-devel] [ webware-Patches-666560 ] Let non reletive urls work in forward() and includeURL()

[SourceForge.net <no...@so...>]

Patches item #666560, was opened at 2003-01-11 23:48
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=304866&aid=666560&group_id=4866

Category: WebKit
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Luke Holden (lholden)
Assigned to: Stuart Donaldson (stuartd)
Summary: Let non reletive urls work in forward() and includeURL()

Initial Comment:
if you use:
self.forward("/someurl")

It is treated reletive to the current directory.

So if you are in the directory
/auth/actions

you get:
/auth/actions/someurl

which is not what you would expect...

This patch changes forward and includeURL to detect if
your trying to use a file from the root directory, and
if you are.. adds req.siteRoot() as needed.

so self.forward("/someurl")
will work as expected

however:
so self.forward("someurl")
will still work reletive to the current directory.


----------------------------------------------------------------------

>Comment By: Stuart Donaldson (stuartd)
Date: 2003-01-14 12:21

Message:
Logged In: YES 
user_id=326269

I am attatching a revised patch.  It is a tarball containing
a diff which includes most of what Luke had already done.  I
moved things around a little, and updated the RelNotes. 

I added some test cases under WebKit/Testing at the end of
the test list.

----------------------------------------------------------------------

Comment By: Luke Holden (lholden)
Date: 2003-01-12 21:50

Message:
Logged In: YES 
user_id=56099

Okay, attached is another patch. (Application_lholden2.diff)
It fixes the problem with includes after a forward.

Apply this after the first patch



----------------------------------------------------------------------

Comment By: Luke Holden (lholden)
Date: 2003-01-12 15:36

Message:
Logged In: YES 
user_id=56099

Unfortunatly... it looks like an includeURL right after a
forward does not work =/

For some reason transaction.request().serverSidePath()  
gets set to None

  File
"/home/alterself/public_html/lib/layout/SiteLayout.py", line
6, in writeHTMLBody
    self.includeURL("/navigation/nav")
  File "./WebKit/Page.py", line 340, in includeURL
  File "/opt/Webware/WebKit/Application.py", line 672, in
includeURL
    self.createServletInTransaction(trans)
  File "/opt/Webware/WebKit/Application.py", line 1000, in
createServletInTransaction
    assert path is not None

----------------------------------------------------------------------

Comment By: Stuart Donaldson (stuartd)
Date: 2003-01-12 10:49

Message:
Logged In: YES 
user_id=326269

This is closely related to the path parsing problems I am
looking at right now.  This works in some cases, but on its
own, it fails with ExtraPathInfo in FindServlet I think.

I'm looking into this further right now.  Thanks for the
Patch, I'll likely use a good part of it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=304866&aid=666560&group_id=4866