[Webware-devel] [ webware-Patches-630505 ] Store session pickle error handling

[SourceForge.net <no...@so...>]

Patches item #630505, was opened at 2002-10-29 06:56
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=304866&aid=630505&group_id=4866

Category: WebKit
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Oleg Noga (oleg_noga)
Assigned to: Stuart Donaldson (stuartd)
Summary: Store session pickle error handling

Initial Comment:
if error occurs while pickling session to a file (Session 
can't be pickled), SessionFileStore leaves corrupt 
session file. For all future attempts ro load this session 
into memory we have KeyError, and new session is not 
created.

SessionFileStore.diff patch handles exception while 
pickling session and does not leave corrupt session 
files. So, new session can be created with same key.

DynamicFileStore.diff patch adds a check in MovetoFile, 
(was the session stored properly?), so session can be 
removed from the memory store only if it was saved to a 
file.
---
Patches are maked for checkout on 2002-10-29


----------------------------------------------------------------------

>Comment By: Stuart Donaldson (stuartd)
Date: 2003-01-10 11:06

Message:
Logged In: YES 
user_id=326269

Commited a fix for this bug which was not a direct match to
the patches submitted.

When the pickling exception occurs, now we call
application.handleException() and that takes care of
displaying, as logging, and emailing depending on
configuration.  The session file is not saved and gets lost
as a result.  The fix involved getting the handleException()
in and running as well.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=304866&aid=630505&group_id=4866