Re: Reviewing bugs & patches (Was: RE: [Webware-discuss] Is there a

[Ian B. <ia...@co...>]

On Wed, 2002-10-16 at 16:26, Kendall Grant Clark wrote:
> Short version: First, Tavis's bug report, #621494, should be addressed
> before a new release; at the very least, folks using PSP should see if
> it's replicable; if so, it should be fixed. Second, there's a patch
> against Page.py (v. 1.25) that adds a new method,
> handlePostWithoutAction(), that someone might argue should be applied. 

We talked about handlePostWithoutAction on the -devel list, and though
it wasn't really resolved, it seemed like it was perhaps a problem with
actions on the whole -- a different solution seemed best.

> Longer version:
> 
> Only two bug reports are worth noting since 0.7 release:
> 
> 1) #550156, which is Geoff reporting that turning on ExtraPathInfo is
>    broken; I think that Ian has something in CVS which addresses this,
>    though I may be misremembering.

Yes, it hasn't been very well tested, but it seems to work.  I have to
tweak it a little before a release, but it should fix that bug.

> 2) #621494, which is Tavis's report about PSP parsing bug, that a space
>    after the opening bracket, <, and before psp:method causes a PSP parse
>    error(?). It's filed against the CVS of 2002.09.01.07.00.00, so I'd
>    think this is one that needs to be addressed. I can't replicate it
>    locally as I'm running default 0.7.

I haven't tested it, but the bug probably hasn't gone anywhere.

> As for patches, there are 7 patches since the 0.7 release, near as I can
> tell:
> 
> Two of them are installation, portability issues -- one a fix for start
> and stop scripts, the other makes Webware work nicely with FreeBSD
> ports. Neither of these seems critical.

It looks like the port should be moved to the download section or
something.  The other patch doesn't have any files with it, so there's
nothing to do with it.

> There's a patch addressing encoding support for XML-RPC, but I can't seem
> to download it from SF to review it. It was assigned to Geoff, so this may
> well be taken care of in CVS.
> 
> There's a pair of patches to add Postgresql support to Middlekit, one of
> which is against a Python PG library, which I would think can be
> ignored. The other patch basically adds a class,
> PostgresObjectStore(SQLObjectStore), to Generate.py. Near as I can tell,
> again, this could be dropped.

Yes, no one is really taking Postgres/MiddleKit on, so we shouldn't
integrate anything related to that.

> Another patch adds LRWP/Xitami support to Webkit; again, IIRC, Ian has
> checked in something to CVS along these lines recently?

Yes, I put this into CVS.

> The last two patches are fairly negligible: #608957 adds some
> If-Since-Then support to WebKit, but it seems the common pattern (?) is to
> use Apache to serve static files. Last, #620519 is against Page.py
> v. 1.25, adding a handlePostWithoutAction() method, the implementation of
> which is "pass".

If-Modified-Since support might be good, but it touches a lot, and maybe
it should wait.

> I can't imagine any of this is helpful toward making a new release, but
> there it is.

No, it's a good summary.  Thanks.  I think that leaves us with:

Confirm XMLRPC was fixed (Geoff)
Fix the PSP bug
Update the documentation (it really needs it)
Do all the release stuff
Maybe get Stefan to update the BSD port with the new release, and align
versions (i.e., the port version should match the Webware version)

Oh, and troll about for more bugs, some of which may be out there but
not listed in the tracker.

  Ian