[Vxl-maintainers] include vcl_compiler.h kept in some files

[Wheeler, F. (CRD) <wh...@cr...>]

I removed the #include <vcl_compiler.h> from the files I recently changed that also include a vcl_
ISO header, which will in turn include vcl_compiler.h.  There were 13 files in which I left the
#include <vcl_compiler.h> because no vcl_ ISO header is included directly.  FYI, they are ...

./vxl/vul/vul_get_timestamp.cxx
./gel/gtrl/gtrl_triangulation.cxx
./oxl/vgui/dll.h
./oxl/vgui/vgui_glut.h
./oxl/vgui/vgui_linker_hack.h
./oxl/vgui/examples/geoff/vgui_testbed/vgui_testbed.cxx
./oxl/vgui/impl/Fl/vgui_Fl_window.cxx
./oxl/vgui/internals/vgui_accelerate_tag.cxx
./oxl/xcv/xcv_twoview_manager.cxx
./vxl/vbl/dll.h
./vxl/vbl/vbl_hash_map.txx
./vxl/vnl/dll.h
./vxl/vnl/algo/dll.h

Fred Wheeler

--
Fred Wheeler, GE CRD, KWC-303
Phone: 518-387-7225 (GE Internal Dialcom: 8*833-7225)
Fax:   518-387-4042 (GE Internal Dialcom: 8*833-4042)


-----Original Message-----
From: Frederik Schaffalitzky [mailto:fs...@ro...]
Sent: Thursday, March 21, 2002 10:40 AM
To: Ian Scott
Cc: 'Fred Wheeler'; Vxl-maintainers (E-mail)
Subject: Re: [Vxl-maintainers] RE: [Vxl-commit] CVS: vxl/vxl/vul
vul_reg_exp.cxx,1.3,1.4



I may have mentioned it before, but there is also an oldish discussion of
this issue in vcl/README.

To answer your question, I agree with what you have said, with the proviso
that a header file, such as vbl_triple.h, which does not use any headers
from the standard library is allowed to include vcl_compiler.h directly.

Frederik



On Thu, 21 Mar 2002, Ian Scott wrote:

> Fred,
> 
> Did you mention about putting the #include<vcl_compiler.h> in to the files
> in your previous emails? If so I'm sorry I didn't pick it up then.
> 
> I don't think things should refer to vcl_compiler.h (or any of the other
> non-ansi files in vcl) unless it is absolutely essential.
> 
> In the example below it shouldn't be necessary, because   #include
> <vcl_iostream.h> will in turn #include vcl_compiler.h
> 
> Indeed all of the proper ansi headers in vcl (should) #include
> vcl_compiler.h, etc. Therefore any vxl file simply needs to #include just
> one standard vcl header to get the benefit of vcl_compiler.h
> 
> Ian
> 
> > -----Original Message-----
> > From: Fred Wheeler [mailto:fre...@us...]
> > Sent: Thursday, March 21, 2002 3:19 PM
> > To: vxl...@li...
> > Subject: [Vxl-commit] CVS: vxl/vxl/vul vul_reg_exp.cxx,1.3,1.4
> >
> >
> > Update of /cvsroot/vxl/vxl/vxl/vul
> > In directory usw-pr-cvs1:/tmp/cvs-serv18463/vxl/vul
> >
> > Modified Files:
> > 	vul_reg_exp.cxx
> > Log Message:
> > use VCL_WIN32 instead of WIN32, and include vcl_compiler.h
> >
> > Index: vul_reg_exp.cxx
> > ===================================================================
> > RCS file: /cvsroot/vxl/vxl/vxl/vul/vul_reg_exp.cxx,v
> > retrieving revision 1.3
> > retrieving revision 1.4
> > diff -C2 -r1.3 -r1.4
> > *** vul_reg_exp.cxx	16 Feb 2002 10:29:06 -0000	1.3
> > --- vul_reg_exp.cxx	21 Mar 2002 15:19:01 -0000	1.4
> > ***************
> > *** 121,124 ****
> > --- 121,125 ----
> >
> >   #include "vul_reg_exp.h"
> > + #include <vcl_compiler.h>
> >   #include <vcl_iostream.h>
> >   #include <vcl_cstring.h>
> > ***************
> > *** 403,407 ****
> >
> >       // Allocate space.
> > ! //#ifndef WIN32
> >       if (this->program != NULL) delete [] this->program;
> >   //#endif
> > --- 404,408 ----
> >
> >       // Allocate space.
> > ! //#ifndef VCL_WIN32
> >       if (this->program != NULL) delete [] this->program;
> >   //#endif
> >
> >
> > _______________________________________________
> > Vxl-commit mailing list
> > Vxl...@li...
> > https://lists.sourceforge.net/lists/listinfo/vxl-commit
> >
> 
> 
> _______________________________________________
> Vxl-maintainers mailing list
> Vxl...@li...
> https://lists.sourceforge.net/lists/listinfo/vxl-maintainers
>